gh-122858: Deprecate asyncio.iscoroutinefunction
#122875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect.iscoroutinefunction`.
Wulian233
requested review from
cjw296,
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
|
After my many fix, maybe it is normal for the Docs workflow to fail because the deprecated function But I don't know how to solve this problem. Delete whatnew/3.14.rst: (Solved) |
Misc/NEWS.d/next/Library/2024-08-10-10-21-44.gh-issue-122858.ZC1rJD.rst
Outdated
Show resolved
Hide resolved
sobolevn
reviewed
Aug 11, 2024
|
This is the function that test this function c1f2743 If not have @ignore_warnings(category=DeprecationWarning)
def test_iscoroutinefunction(self):
print("asyncio.iscoroutinefunction is deprecated, use inspect.iscoroutinefunction() instead")
def fn():
...(Sorry, I may not be familiar with it) |
|
I am taking over this now. |
kumaraditya303
approved these changes
Aug 11, 2024
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
Deprecate `asyncio.iscoroutinefunction` in favor of `inspect.iscoroutinefunction`. Co-authored-by: Kumar Aditya <kumaraditya@python.org>
AdamWill
pushed a commit
to AdamWill/cached-property
that referenced
this pull request
Nov 5, 2024
Python 3.14 will deprecate asyncio.iscoroutinefunction: python/cpython#122875 inspect.iscoroutinefunction exists since 3.5 and our baseline is 3.8, so we can just use it unconditionally. Using a wrapper with @asyncio.coroutine in __get__ wasn't necessary (the future from asyncio.ensure_future is awaitable, and the wrapper doesn't do anything asynchronous), so the logic can be simplified to just call asyncio.ensure_future (to schedule the task and store the result when it's available).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same
inspect.iscoroutinefunction, we don't need two different functions to do the same thing.asyncio.iscoroutinefunction#122858